support US#652
Conversation
|
I don't think this modification is necessary to support it. Just set the value of BaseAPIMainURL or BaseWsMainURL before creating the client. Except in the options module where the associated values are not publicly available, if options support is also required, the associated values can be modified to be publicly visible. @eddieran |
|
I modified it this way with reference to the current support for testnet's domain. |
|
@eddieran Take a look at those comments. |
|
Can anyone please approve the change on Test Network Websocket URLs? The old domains are no longer supported, and I am receiving 'websocket: bad handshake' error when calling the |
|
@JimBeam2019 — this PR adds @xyq-c-cpp — sorry for the long silence. Re-reading your earlier comment, I agree the public-variable approach is cleaner. The PR currently exposes a flag rather than rewriting endpoints, which I think keeps it minimal: |
support binance.us